Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#570 confirmPopup을 overlay를 활용하도록 변경 #571

Merged
merged 3 commits into from
May 13, 2024
Merged

Refactor/#570 confirmPopup을 overlay를 활용하도록 변경 #571

merged 3 commits into from
May 13, 2024

Conversation

cruelladevil
Copy link
Collaborator

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명(이미지 첨부 가능)

  • confirmPopup을 overlay를 활용하도록 변경
  • confirmPopup을 사용한 곳 리팩터링

#️⃣연관된 이슈

연관된 이슈 번호를 모두 작성

close #570

@cruelladevil cruelladevil added [ 🌞 FE ] 프론트엔드 크루들의 빛나는 개발 이야기 하나둘셋 호! 🔨 Refactor 꾸준한 개선이 더 나은 애플리케이션을 만든다 labels May 13, 2024
@cruelladevil cruelladevil self-assigned this May 13, 2024
@github-actions GitHub Actions
Copy link

Unit Test Results

  98 files    98 suites   10s ⏱️
389 tests 388 ✔️ 1 💤 0 ❌
394 runs  393 ✔️ 1 💤 0 ❌

Results for commit 8393cf9.

@cruelladevil cruelladevil merged commit ed0666b into main May 13, 2024
4 checks passed
@cruelladevil cruelladevil deleted the refactor/#570 branch May 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Creative-Lee Creative-Lee Awaiting requested review from Creative-Lee Creative-Lee is a code owner

@ukkodeveloper ukkodeveloper Awaiting requested review from ukkodeveloper ukkodeveloper is a code owner

Assignees

@cruelladevil cruelladevil

Labels
[ 🌞 FE ] 프론트엔드 크루들의 빛나는 개발 이야기 하나둘셋 호! 🔨 Refactor 꾸준한 개선이 더 나은 애플리케이션을 만든다
Projects
2023-shook
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] confirmPopup을 overlay를 활용하도록 변경
1 participant
@cruelladevil